salesforce-marketingcloud / FuelSDK-Ruby

Fuel SDK for Ruby

BSD 3-Clause "New" or "Revised" License

52 stars 155 forks source link

Update Dependencies #101

Open james-prodigy opened 5 years ago

james-prodigy commented 5 years ago

Changes

Update the dependencies in the project.

How

Change Versions in gemfile bundle upgrade

Issues

Fixes: #97

chezsmithy commented 5 years ago

+1 for getting this merged ASAP. We are blocked on using this SDK based on the dependencies.

rcranley commented 5 years ago

++1 For this. Anything we can do to help it merge? @sfdrogojan @epdejager

rcranley commented 5 years ago

@james-prodigy I would suggest bumping the version in lib/marketingcloudsdk/version.rb

james-prodigy commented 5 years ago

Great thinking @rcranley I'll push an update tomorrow morning.

james-prodigy commented 4 years ago

Anything else I can do? @rcranley @sfdrogojan

ghost commented 4 years ago

@james-prodigy, I think there is one more place where the version needs a bump. In Gemfile.lock, in PATH / specs / sfmc-fuelsdk-ruby, I currently see a 1.3.0 there.

chvreddy commented 4 years ago

@james-prodigy when can we expect this to merge to master, we have dependency on marketingcloudsdk gem and need this PR to get merged

james-prodigy commented 4 years ago

@barberj Do you know when we can see this being merged in?

guitarama commented 4 years ago

There were some changes mentioned in #7 related to updates in savon (related to updates in gyoku). I opened an alternative to this PR that relaxes the requirement a bit (~> 2.3) and incorporates those changes: #112

chvreddy commented 4 years ago

@barberj Waiting for this to get merged to master

james-prodigy commented 4 years ago

@guitarama can I rebase this into your branch? that way we can incorporate the minor version bump

barberj commented 4 years ago

@james-prodigy I'm not apart of salesforce-marketingcloud org.