search

salesforce-ux / design-system-starter-kit

Rapid prototyping environment using the Salesforce Lightning Design System
https://starter-kit-demo.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
355 stars 569 forks source link

npm run dev fails on node v4.4.0 #28

Closed davixyz closed 6 years ago

davixyz commented 7 years ago

Hi Salesforce Team,

In the documentation it outlines that we can use Node V4.2+ for the project, currently i'm running Node: v4.4.0 & NPM: 3.10.9

Upon installing everything and running npm run dev I get:

[16:56:12] Plumber found unhandled error:
 TypeError in plugin 'gulp-autoprefixer'
Message:
    this is not a typed array.
Details:
    fileName: ~/design-system-starter-kit/src/styles/index.css
Stack:
TypeError: this is not a typed array.
    at Function.from (native)
    at ~/design-system-starter-kit/node_modules/gulp-autoprefixer/index.js:25:27
    at process._tickCallback (node.js:369:9)
[16:56:12] Finished 'scripts' after 1.41 s

I did a quick search and it appears that the version of the autoprefixer used uses a feature is only available on node V4.5+ https://github.com/sindresorhus/gulp-autoprefixer/issues/83

I guess there's need to update documentation to outline V4.5 minimun or downgrade the autoprefixer version to 3+ in order for it to be compatible; Thoughts?

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.