search

salesforce-ux / theo

Theo is a an abstraction for transforming and formatting Design Tokens
BSD 3-Clause "New" or "Revised" License
1.96k stars 117 forks source link

Diversify test suite fixtures? #161

Open morewry opened 6 years ago

morewry commented 6 years ago

I noticed that the fixtures for testing the formats all seem to use roughly the same input format, with the properties named using the constant-convention-esque UPPER_SNAKE_CASE.

This means the tests really only cover your cases if you use the same naming convention for your tokens. Since theo's users probably have more diverse input, I wonder if you'd be open to more diverse fixtures that will also provide more complete coverage of what the formats are actually doing (some of the functions applied to e.g. property names will change the output of things like spaces and hyphens, which aren't being reflected in/covered by the test suite currently).

aputinski commented 6 years ago

Yeah, I think expanding the test cases would be a great idea.