salesforce / Argus

Time series monitoring and alerting platform.
BSD 3-Clause "New" or "Revised" License
505 stars 145 forks source link

Allowing openTSDB 2.3 aggregators #458

Open wistefan opened 7 years ago

wistefan commented 7 years ago

We are currently use Argus with openTSDB 2.3. I've seen that Argus checks the expressions with the MetricsReader and only allows aggregators up to openTSDB version 2.0, thus aggregators like "count", "last", "first", "none" and all the percentile stuff are not available for expressions. Is there a reason for that filtering or can we simply extend the aggregators list and use all openTSDB functions available in 2.3? Best regards, Stefan

bsura commented 7 years ago

You can create a PR to enable other aggregators that were added in 2.3 version. Although we would like to keep it to bare minimum so that we are not tightly coupled to OpenTSDB. Pretty soon, we will have other implementations of the TSDBService and then those implementations would have to provide these kinds of aggregations.

I would recommend you use Argus Transforms as much as you can and only rely on certain basic OpenTSDB aggregators

wistefan commented 7 years ago

Thank you for the response. I understand that you don't want that tight coupling. But how does the performance of the transforms compare to the native openTSDB aggregators? Do you have any experience how the percentile-transform or the count compares to the same aggregators in tsdb in terms of performance? Best regards, Stefan

rajsarkapally commented 6 years ago

We have created a story to add more aggregations..