salesforce / GQUIC_Protocol_Analyzer

GQUIC Protocol Analyzer for Zeek (Bro) Network Security Monitor
Other
75 stars 22 forks source link

Fix warning about out-of-scope variable GQUIC::cable_hash #16

Closed mmguero closed 2 years ago

mmguero commented 2 years ago

The string cable_hash is used in main.zeek outside of the scope of its local declaration.

found/fixed/tested with Zeek v5.0.0 in docker, Debian 11 x86_64

Before this fix:

 zeek -NN local 2>&1 | grep -i quic
warning in /opt/zeek/share/zeek/site/packages/./GQUIC_Protocol_Analyzer/./main.zeek, line 76: use of out-of-scope local GQUIC::cable_hash deprecated; move declaration to outer scope
Salesforce::GQUIC - Google QUIC (GQUIC) protocol analyzer for Q039-Q046 (dynamic, version 1.0.0)
    [Analyzer] GQUIC (ANALYZER_GQUIC, enabled)
    [Event] gquic_packet
    [Event] gquic_client_version
    [Event] gquic_hello
    [Event] gquic_rej
    [Constant] GQUIC::skip_after_confirm
    [Type] GQUIC::HelloInfo
    [Type] GQUIC::PublicHeader
    [Type] GQUIC::RejInfo

After the fix:

> zeek -NN local 2>&1 | grep -i quic
Salesforce::GQUIC - Google QUIC (GQUIC) protocol analyzer for Q039-Q046 (dynamic, version 1.0.0)
    [Analyzer] GQUIC (ANALYZER_GQUIC, enabled)
    [Event] gquic_packet
    [Event] gquic_client_version
    [Event] gquic_hello
    [Event] gquic_rej
    [Constant] GQUIC::skip_after_confirm
    [Type] GQUIC::HelloInfo
    [Type] GQUIC::PublicHeader
    [Type] GQUIC::RejInfo

Signed-off-by: Seth Grover mero.mero.guero@gmail.com

salesforce-cla[bot] commented 2 years ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Seth Grover m***@g***.com. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.