search

salesforce / Merlion

Merlion: A Machine Learning Framework for Time Series Intelligence
BSD 3-Clause "New" or "Revised" License
3.43k stars 302 forks source link

[BUG] #82

Closed sunxin000 closed 2 years ago

sunxin000 commented 2 years ago

Describe the bug when i run python benchmark_forecast.py --model ets --retrain_type sliding_window_retrain --n_retrain 4 retrain seems didnt work. the model is only trained once.

i think that there is sometion wrong with the ForecastEvaluatorConfig.cadence, it is set to be the horizon, which is the lenth of the test_set, not the retrain_freq, so when one loop is done, t adding to the cadence larger then tf, the train procedure is over.

aadyotb commented 2 years ago

Thanks for pointing this out. PR #86 fixes the issue.