salesforce / TransmogrifAI

TransmogrifAI (pronounced trăns-mŏgˈrə-fī) is an AutoML library for building modular, reusable, strongly typed machine learning workflows on Apache Spark with minimal hand-tuning
https://transmogrif.ai
BSD 3-Clause "New" or "Revised" License
2.24k stars 393 forks source link

Fixed onSetInput so is always called with new input #280

Closed leahmcguire closed 5 years ago

leahmcguire commented 5 years ago

Related issues Metadata for transformers was not being updated when raw feature filter removed features

Describe the proposed solution Moved onSetInput call into the base (internal) set input call

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context about the changes here.

codecov[bot] commented 5 years ago

Codecov Report

Merging #280 into master will increase coverage by 0.01%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #280      +/-   ##
=========================================
+ Coverage   86.39%   86.4%   +0.01%     
=========================================
  Files         319     319              
  Lines       10450   10453       +3     
  Branches      354     561     +207     
=========================================
+ Hits         9028    9032       +4     
+ Misses       1422    1421       -1
Impacted Files Coverage Δ
.../op/stages/impl/feature/TextMapNullEstimator.scala 100% <ø> (ø) :arrow_up:
...la/com/salesforce/op/stages/OpPipelineStages.scala 62.5% <ø> (-1.02%) :arrow_down:
...sforce/op/stages/impl/feature/Transmogrifier.scala 96.9% <ø> (ø) :arrow_up:
...rce/op/stages/impl/preparators/SanityChecker.scala 91.59% <0%> (-0.25%) :arrow_down:
...m/salesforce/op/stages/OpPipelineStageParams.scala 91.66% <100%> (+0.49%) :arrow_up:
...orce/op/stages/impl/feature/BinaryVectorizer.scala 100% <100%> (ø) :arrow_up:
...e/op/stages/impl/feature/TextMapLenEstimator.scala 100% <100%> (ø) :arrow_up:
.../op/features/types/FeatureTypeSparkConverter.scala 99.11% <0%> (+0.88%) :arrow_up:
.../scala/com/salesforce/op/dsl/RichTextFeature.scala 86.56% <0%> (+1.49%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e64ff6...e34c26f. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #280 into master will decrease coverage by 26.25%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #280       +/-   ##
===========================================
- Coverage   86.39%   60.14%   -26.26%     
===========================================
  Files         319      319               
  Lines       10440    10692      +252     
  Branches      350      546      +196     
===========================================
- Hits         9020     6431     -2589     
- Misses       1420     4261     +2841
Impacted Files Coverage Δ
...la/com/salesforce/op/stages/OpPipelineStages.scala 36.98% <ø> (-26.53%) :arrow_down:
...m/salesforce/op/stages/OpPipelineStageParams.scala 91.66% <100%> (+0.49%) :arrow_up:
...ages/impl/feature/MultiPickListMapVectorizer.scala 0% <0%> (-100%) :arrow_down:
...la/com/salesforce/op/aggregators/Geolocation.scala 0% <0%> (-100%) :arrow_down:
.../salesforce/op/aggregators/FeatureAggregator.scala 0% <0%> (-100%) :arrow_down:
...lesforce/op/stages/impl/feature/LangDetector.scala 0% <0%> (-100%) :arrow_down:
...alesforce/op/cli/gen/templates/SimpleProject.scala 0% <0%> (-100%) :arrow_down:
...sforce/op/stages/base/unary/UnaryTransformer.scala 0% <0%> (-100%) :arrow_down:
...e/op/stages/impl/feature/TextMapLenEstimator.scala 0% <0%> (-100%) :arrow_down:
.../op/stages/base/sequence/SequenceTransformer.scala 0% <0%> (-100%) :arrow_down:
... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e95804...8d02a1c. Read the comment docs.

tovbinm commented 5 years ago

@leahmcguire there are some build failures you might want to look into.