search

salesforce / TransmogrifAI

TransmogrifAI (pronounced trăns-mŏgˈrə-fī) is an AutoML library for building modular, reusable, strongly typed machine learning workflows on Apache Spark with minimal hand-tuning
https://transmogrif.ai
BSD 3-Clause "New" or "Revised" License
2.24k stars 393 forks source link

Updated TextMapPivotVectorizerTest to use OpEstimatorSpec #290

Closed tovbinm closed 5 years ago

tovbinm commented 5 years ago

Related issues

TextMapPivotVectorizerTest is not using OpEstimatorSpec

Describe the proposed solution

  1. Updated TextMapPivotVectorizerTest to use OpEstimatorSpec
  2. Remove VectorizerDefaults mixin from TextMapPivotVectorizer and TextMapPivotVectorizerModel
codecov[bot] commented 5 years ago

Codecov Report

Merging #290 into master will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage    86.4%   86.42%   +0.01%     
==========================================
  Files         319      319              
  Lines       10453    10452       -1     
  Branches      351      346       -5     
==========================================
+ Hits         9032     9033       +1     
+ Misses       1421     1419       -2
Impacted Files Coverage Δ
...scala/com/salesforce/op/test/OpEstimatorSpec.scala 93.33% <ø> (-0.22%) :arrow_down:
...p/stages/impl/feature/TextMapPivotVectorizer.scala 100% <ø> (ø) :arrow_up:
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.79% <0%> (+4.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b3edfe...e87d23d. Read the comment docs.