michaelweilsalesforce commented 5 years ago

Related issues FeatureDistribution contains the field key which is the map key associated with distribution (when the feature is a map). But why not having the same field in RawFeatureFilterMetrics and ExclusionReasons?

Describe the proposed solution Adding the same field in RawFeatureFilterMetrics and ExclusionReasons

Describe alternatives you've considered

Additional context

codecov[bot] commented 5 years ago

Codecov Report

Merging #348 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff            @@
##           master     #348    +/-   ##
========================================
  Coverage   86.65%   86.65%            
========================================
  Files         335      335            
  Lines       10763    10763            
  Branches      344      562   +218     
========================================
  Hits         9327     9327            
  Misses       1436     1436

Impacted Files	Coverage Δ
...alesforce/op/filters/RawFeatureFilterResults.scala	`100% <ø> (ø)`	:arrow_up:
...a/com/salesforce/op/filters/RawFeatureFilter.scala	`92.93% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update afc910c...a8e7794. Read the comment docs.

salesforce-cla[bot] commented 3 years ago

Thanks for the contribution! It looks like @mweilsalesforce is an internal user so signing the CLA is not required. However, we need to confirm this.

salesforce / TransmogrifAI

Adding `key` ctor field in all RawFeatureFilter results #348

Codecov Report