salesforce / TransmogrifAI

TransmogrifAI (pronounced trăns-mŏgˈrə-fī) is an AutoML library for building modular, reusable, strongly typed machine learning workflows on Apache Spark with minimal hand-tuning
https://transmogrif.ai
BSD 3-Clause "New" or "Revised" License
2.24k stars 392 forks source link

Property-based GLM test #427

Closed michaelweilsalesforce closed 4 years ago

michaelweilsalesforce commented 4 years ago

Related issues Adding more Tests for our ML capabilities (TDD)

Describe the proposed solution Property based tests to check each of our the Regression Models (Linear Regression, Random Forest, GLM) will be picked based on the nature of the data (and response) generated

Describe alternatives you've considered Doing the same tests on one single dataset instead

tovbinm commented 4 years ago

@michaelweilsalesforce please update PR description. also, is it ready for review?

michaelweilsalesforce commented 4 years ago

@Jauntbox These tests are actually painful for our runtime (~15-20 mins/ unit test)

tovbinm commented 4 years ago

Builds will be killed if not output is produced for 10 minutes, so we can’t have an individual test take longer than that.

codecov[bot] commented 4 years ago

Codecov Report

Merging #427 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
+ Coverage   86.94%   86.96%   +0.01%     
==========================================
  Files         337      337              
  Lines       11082    11083       +1     
  Branches      355      356       +1     
==========================================
+ Hits         9635     9638       +3     
+ Misses       1447     1445       -2
Impacted Files Coverage Δ
.../src/main/scala/com/salesforce/op/OpWorkflow.scala 88.88% <ø> (ø) :arrow_up:
...com/salesforce/op/utils/stages/FitStagesUtil.scala 94.8% <100%> (+0.06%) :arrow_up:
...es/src/main/scala/com/salesforce/op/OpParams.scala 85.71% <0%> (-4.09%) :arrow_down:
...in/scala/com/salesforce/op/cli/gen/AvroField.scala 76.92% <0%> (+2.56%) :arrow_up:
...cala/com/salesforce/op/cli/gen/ProblemSchema.scala 96.55% <0%> (+5.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8bae1c...109fab1. Read the comment docs.