salesforce / TransmogrifAI

TransmogrifAI (pronounced trăns-mŏgˈrə-fī) is an AutoML library for building modular, reusable, strongly typed machine learning workflows on Apache Spark with minimal hand-tuning
https://transmogrif.ai
BSD 3-Clause "New" or "Revised" License
2.24k stars 392 forks source link

make helloworld a subproject #441

Closed nicodv closed 4 years ago

nicodv commented 4 years ago

Related issues https://github.com/salesforce/TransmogrifAI/issues/87

Describe the proposed solution helloworld is now a subproject

Describe alternatives you've considered N/A

Additional context See discussion in https://github.com/salesforce/TransmogrifAI/pull/254

I've tested the build and the helloworld examples, which still run fine.

nicodv commented 4 years ago

Played around with Gradle and made helloworld a subproject. This DRYs up the code, but not sure if it's desired. Let me know if it's useful.

tovbinm commented 4 years ago

@nicodv thanks for the effort. The idea was to have a Helloworld to build against the latest release and not the master branch. I would rather extract it out as a separate project. In fact we already did so with for sbt - https://github.com/salesforce/transmogrifai-helloworld-sbt

nicodv commented 4 years ago

I see, @tovbinm . I interpreted helloworld as example code against the current API (i.e. master), and the templates directory the thing you would want to separate out for others to base their own work on and adapt.

gerashegalov commented 4 years ago

Thanks @nicodv, your RP is what I was thinking in terms of #254. But it's indeed better to move all the examples to transmogrifai-helloworld-sbt as @tovbinm points out to increase DRYness even more :). And we can see if we can set up a build chain such that PR check includes the build of transmogrifai-helloworld-sbt on the TransmogrifAI PR branch as we do internally.

codecov[bot] commented 4 years ago

Codecov Report

Merging #441 into master will decrease coverage by 2.19%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #441     +/-   ##
=========================================
- Coverage   86.93%   84.74%   -2.2%     
=========================================
  Files         337      350     +13     
  Lines       11096    11383    +287     
  Branches      362      363      +1     
=========================================
  Hits         9646     9646             
- Misses       1450     1737    +287
Impacted Files Coverage Δ
...cala/com/salesforce/hw/boston/BostonFeatures.scala 0% <0%> (ø)
...in/scala/com/salesforce/hw/iris/IrisFeatures.scala 0% <0%> (ø)
...main/scala/com/salesforce/hw/OpTitanicSimple.scala 0% <0%> (ø)
...rc/main/scala/com/salesforce/hw/OpIrisSimple.scala 0% <0%> (ø)
...la/com/salesforce/hw/titanic/TitanicFeatures.scala 0% <0%> (ø)
...alesforce/hw/dataprep/ConditionalAggregation.scala 0% <0%> (ø)
...in/scala/com/salesforce/hw/titanic/OpTitanic.scala 0% <0%> (ø)
...main/scala/com/salesforce/hw/boston/OpBoston.scala 0% <0%> (ø)
.../main/scala/com/salesforce/hw/OpBostonSimple.scala 0% <0%> (ø)
...salesforce/hw/titanic/TitanicKryoRegistrator.scala 0% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e45073d...d580a10. Read the comment docs.