search

salesforce / TransmogrifAI

TransmogrifAI (pronounced trăns-mŏgˈrə-fī) is an AutoML library for building modular, reusable, strongly typed machine learning workflows on Apache Spark with minimal hand-tuning
https://transmogrif.ai
BSD 3-Clause "New" or "Revised" License
2.24k stars 393 forks source link

Avoid having to have an implicit SparkSession in OpWorkFlow(Model) #468

Closed nicodv closed 4 years ago

nicodv commented 4 years ago

Related issues N/A

Describe the proposed solution Avoid having to provide a SparkSession implicit to OpWorkflow.loadModel/OpWorkflowModel.save to keep backward compatibility.

Describe alternatives you've considered N/A

Additional context Small follow-up on https://github.com/salesforce/TransmogrifAI/pull/467

codecov[bot] commented 4 years ago

Codecov Report

Merging #468 into master will increase coverage by 5.74%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
+ Coverage   81.25%   86.99%   +5.74%     
==========================================
  Files         345      345              
  Lines       11616    11614       -2     
  Branches      376      374       -2     
==========================================
+ Hits         9438    10104     +666     
+ Misses       2178     1510     -668
Impacted Files Coverage Δ
.../src/main/scala/com/salesforce/op/OpWorkflow.scala 88.11% <100.00%> (ø)
...main/scala/com/salesforce/op/OpWorkflowModel.scala 93.90% <100.00%> (+14.63%) :arrow_up:
...cala/com/salesforce/op/OpWorkflowModelReader.scala 95.58% <100.00%> (+11.53%) :arrow_up:
...cala/com/salesforce/op/OpWorkflowModelWriter.scala 100.00% <100.00%> (ø)
...com/salesforce/op/features/types/FeatureType.scala 95.95% <0.00%> (+1.01%) :arrow_up:
...scala/com/salesforce/op/features/FeatureLike.scala 43.47% <0.00%> (+1.08%) :arrow_up:
.../op/features/types/FeatureTypeSparkConverter.scala 99.12% <0.00%> (+1.75%) :arrow_up:
...scala/com/salesforce/op/testkit/RandomStream.scala 100.00% <0.00%> (+2.38%) :arrow_up:
.../com/salesforce/op/local/MLeapModelConverter.scala 10.25% <0.00%> (+2.56%) :arrow_up:
.../scala/com/salesforce/op/dsl/RichTextFeature.scala 81.94% <0.00%> (+2.77%) :arrow_up:
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da52ad9...6714e16. Read the comment docs.