Closed winterslu closed 4 years ago
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Winters Lu k***@s***.com. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.
Merging #474 into master will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #474 +/- ##
=======================================
Coverage 86.99% 86.99%
=======================================
Files 345 345
Lines 11622 11624 +2
Branches 392 386 -6
=======================================
+ Hits 10110 10112 +2
Misses 1512 1512
Impacted Files | Coverage Δ | |
---|---|---|
...c/main/scala/com/salesforce/op/ModelInsights.scala | 93.11% <100.00%> (+0.04%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dc33ada...bffa509. Read the comment docs.
@gerashegalov this is fixing the final missing piece of very old bug, need to get this merged so we can move forward
Related issues Tokens of text field are printing out while internal usage.
Describe the proposed solution Ignore cardinality field in modelInsights serialization, addition to featureDistribution
Additional context Previous PR #420 & #438 & #447