Fix code styling issues

[tovbinm]

Related issues Scalastyle warnings clutter build output

Describe the proposed solution Corrected all the problematic code parts.

Describe alternatives you've considered N/A

Additional context N/A

[codecov[bot]]

Codecov Report

Merging #485 into master will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   87.00%   87.01%           
=======================================
  Files         345      345           
  Lines       11680    11680           
  Branches      378      378           
=======================================
+ Hits        10162    10163    +1     
+ Misses       1518     1517    -1     

Impacted Files	Coverage Δ
...c/main/scala/com/salesforce/op/ModelInsights.scala	93.04% <ø> (ø)
...p/stages/impl/feature/SmartTextMapVectorizer.scala	100.00% <ø> (ø)
...p/stages/impl/selector/SelectedModelCombiner.scala	93.50% <ø> (ø)
.../op/stages/impl/feature/GenderDetectStrategy.scala	45.00% <ø> (ø)
...salesforce/op/stages/impl/feature/TimePeriod.scala	25.00% <ø> (ø)
.../op/features/types/FeatureTypeSparkConverter.scala	99.12% <0.00%> (+0.87%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9017e5...aa88175. Read the comment docs.

[tovbinm]

Can anyone review & approve?

[gerashegalov]

Thanks, @tovbinm! are you implicitly suggesting to require failOnWarning?

[tovbinm]

We used to have that, but a lot of folks complained.

BTW, I would rather recommend moving the codebase to scalafmt and scalafix. Both are excellent and mature tools that greatly improve the quality of the codebase.

We extensively use them to autoformat code on save and on pre-commit hook with git.