salesforce / WikiSQL

A large annotated semantic parsing corpus for developing natural language interfaces.

BSD 3-Clause "New" or "Revised" License

1.62k stars 322 forks source link

lock records dependency version, fix #36 #37

Closed izgzhen closed 5 years ago

salesforce-cla[bot] commented 5 years ago

Thanks for the contribution! Before we can merge this, we need @izgzhen to sign the Salesforce.com Contributor License Agreement.

vzhong commented 5 years ago

Hi @izgzhen Thanks for your help. Is this fix redundant with the changes in #38 ? I'm not exactly sure what happened. It looks like records was updated in a way that breaks backwards compatibility?

izgzhen commented 5 years ago

38 looks a better fix -- but I am not sure. I suggest you try #38 out, and if it works both for you and for CI, then see the result of `pip freeze` and lock the versions. This will prevent compatibility issues in future.

vzhong commented 5 years ago

Thanks! It does look like this is also fixed by #38

salesforce / WikiSQL

lock records dependency version, fix #36 #37

38 looks a better fix -- but I am not sure. I suggest you try #38 out, and if it works both for you and for CI, then see the result of pip freeze and lock the versions. This will prevent compatibility issues in future.

38 looks a better fix -- but I am not sure. I suggest you try #38 out, and if it works both for you and for CI, then see the result of `pip freeze` and lock the versions. This will prevent compatibility issues in future.