salesforce / akita

🚀 State Management Tailored-Made for JS Applications
https://salesforce.github.io/akita/
Apache License 2.0
3.7k stars 342 forks source link

Fix/angular 14 #1038

Closed nerumo closed 1 year ago

nerumo commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Akita is incompatibility with the last Typescript version, 4.8, used on NX and Angular 14 by default.

Issue Number: #870

What is the new behavior?

Akita can be used on typescript 4.8

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

NX workspace had to be updated, it changes somes config file slightly.

salesforce-cla[bot] commented 1 year ago

Thanks for the contribution! Before we can merge this, we need @nerumo to sign the Salesforce.com Contributor License Agreement.

nerumo commented 1 year ago

image

what's going with the salesforce CLA?

corsairdnb commented 1 year ago

@NetanelBasal Could you please pay attention to this PR? The issue prevents us from using Akita with latest Typescript and Angular versions, so it's crucial to be fixed ASAP. Thank you!

acn-masatadakurihara commented 1 year ago

@salesforce-datorama-checkmarx This package that your company manage is in a poor state of maintenance, leaving vulnerabilities in the dependencies package, not keeping up with the latest version of Angular, and not being appropriate as OSS. Please review your management system.

https://github.com/salesforce/akita/pull/1037

corsairdnb commented 1 year ago

@jimjag Thank you for merging this! How can we get the new version released on npm?

arizmendiomar commented 1 year ago

Any news about a new release? Does someone knows to whom do we need to reach out to get a new release?