salesforce / akita

🚀 State Management Tailored-Made for JS Applications
https://salesforce.github.io/akita/
Apache License 2.0
3.7k stars 342 forks source link

Please publish the recently merged Angular 14 fix #1045

Closed thatsmeta closed 1 year ago

thatsmeta commented 1 year ago

Is this a regression?

No

Description

Okay, this library is obviously not actively maintained anymore, but can you please just publish the Angular 14 fix to npmjs so we can all update our projects before migrating to a different library?

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in

No response

Anything else?

No response

Do you want to create a pull request?

No

Ketec commented 1 year ago

This also affects angular 15 upgrades - you can no longer roll back TS to an older version.

Can someone trigger the build for this? Or is that only for the repo owner who seem to no longer visit this anymore?

Ketec commented 1 year ago

@NetanelBasal can someone trigger a new release for the changes?

llorenspujol commented 1 year ago

Is quite concerning the low activity this project is having in the last year...

Aside of that, the library still works, is just an annoying typing issue. You can work around it skipping lib check in the tsconfig:

{
    // ...
    "compilerOptions": {
        // ...
        "skipLibCheck": true, 
        // ...
    },
    // ...
}

It is not ideal, but is still better than staying in an older Angular version.

I hope this project takes off again BTW.

Does this Salesforce re-branding affected the continuity of the project? @NetanelBasal

Ketec commented 1 year ago

this doesn't only disable lib check, unfortunately - the name is misleading. It ignores all type declaration files - including ones in your own code/project.

NetanelBasal commented 1 year ago

I'm waiting for some answers from the company behind Akita. I'll consider a fork to ngneat if I'm not satisfied with them.

NetanelBasal commented 1 year ago

The repo is updated now. I'll release new versions soon.

Ketec commented 1 year ago

Is @datorama/akita still under your control or does it need salesforce credentials to publish? A package name change can be quite disruptive (I scanned and there are 108 imports across 6 teams/libraries/modules).

NetanelBasal commented 1 year ago

I'm on it.

Ketec commented 1 year ago

I think something got mixed up now.

entity service now requires a minimum of "@angular/core": ">= 15.0.0",


npm ERR! Could not resolve dependency:
npm ERR! peer @angular/core@">= 15.0.0" from @datorama/akita-ng-entity-service@8.0.0
npm ERR! node_modules/@datorama/akita-ng-entity-service
npm ERR!   @datorama/akita-ng-entity-service@"^8.0.0" from the root project

So it's now incompatible with angular 14. And there is no version compatible with angular 14. So this issue still remains.

Can it use | or for both 14 and 15 support?

NetanelBasal commented 1 year ago

I think you can. You can use npm i --force for now.

WynieCronje commented 1 year ago

In package.json I added below overrides. For me it make sens for these 2 modules. Since library authors always takes a while before updating the dependencies on their side

image

Read More about npm overrides