Redundant code in getdata.sh

salesforce / awd-lstm-lm

LSTM and QRNN Language Model Toolkit for PyTorch

BSD 3-Clause "New" or "Revised" License

1.96k stars 488 forks source link

Redundant code in getdata.sh #36

Closed tariq-hasan-zz closed 6 years ago

tariq-hasan-zz commented 6 years ago

Lines 8-14 and 54-60 in getdata.sh both contain the same lines of code:

echo "- Downloading WikiText-2 (WT2)"
wget --quiet --continue https://s3.amazonaws.com/research.metamind.io/wikitext/wikitext-2-v1.zip
unzip -q wikitext-2-v1.zip
cd wikitext-2
mv wiki.train.tokens train.txt
mv wiki.valid.tokens valid.txt
mv wiki.test.tokens test.txt

I think that lines 54-60 from getdata.sh can be deleted with no consequence.

keskarnitish commented 6 years ago

My recent PR merge fixes this. Thanks for pointing it out.

tariq-hasan-zz commented 6 years ago

You're welcome.