salesforce / aws-allowlister

Automatically compile an AWS Service Control Policy that ONLY allows AWS services that are compliant with your preferred compliance frameworks.
MIT License
221 stars 34 forks source link

Add schedule to update database #75

Closed danquack closed 3 years ago

danquack commented 3 years ago

What does this PR do?

Updates the database every morning. Closes #72

//: # (Required: Describe the effects of your pull request in detail. If multiple changes are involved, a bulleted list is often useful.)

What gif best describes this PR or how it makes you feel?

updates

Completion checklist

salesforce-cla[bot] commented 3 years ago

Thanks for the contribution! Before we can merge this, we need @danquack to sign the Salesforce.com Contributor License Agreement.

kmcquade commented 3 years ago

@danquack - thanks for the contribution! Should it really update every morning?

danquack commented 3 years ago

Screen Shot 2021-04-21 at 2 26 03 PM Looks like there's an error with the CLA

danquack commented 3 years ago

@kmcquade the issue wasn't clear on what the time frame of the cron should be. I live the mindset by let the computers check often so I don't have to, but I think it really depends on salesforce decision of cost of runners and personal preference. FWIW there is an update

kmcquade commented 3 years ago

Let's do it every 2 weeks. Less wait time than monthly, but not so often that it adds significant effort or time spent maintaining

danquack commented 3 years ago

@kmcquade works for me! Theres always that workflow dispatch too in case you see something yourself and just want to run the job.