salesforce / aws-allowlister

Automatically compile an AWS Service Control Policy that ONLY allows AWS services that are compliant with your preferred compliance frameworks.
MIT License
221 stars 34 forks source link

Updates database #78

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

This is an automated PR created because AWS compliances resources were updated.

jdyke commented 3 years ago

@kmcquade I know you're OOO so can I approve / merge this? Anything special I need to kickoff manually afterwards?

kmcquade commented 3 years ago

@jdyke I updated your repository permissions to Maintainer instead of Triager. You should be able to make modifications.

I am not sure why the unit tests aren’t running on this. I’d like to make sure those run successfully before merging. The GitHub action for tests is supposed to run on push and pull request. Easiest temporary fix would be to modify the Readme or push an empty commit, since I’m not aware of a GitHub equivalent for “Jenkins retest this please”. Feel free to do either temp fix or to debug the GitHub action thing, it is up to you :)

jdyke commented 3 years ago

@jdyke I updated your repository permissions to Maintainer instead of Triager. You should be able to make modifications.

Roger, I'll dig into the unit tests! Thanks for the update.