added acm-pca under Certificate Manager

salesforce / aws-allowlister

Automatically compile an AWS Service Control Policy that ONLY allows AWS services that are compliant with your preferred compliance frameworks.

MIT License

221 stars 34 forks source link

added acm-pca under Certificate Manager #81

Closed pkaeding closed 3 years ago

pkaeding commented 3 years ago

What does this PR do?

//: # (Required: Describe the effects of your pull request in detail. If multiple changes are involved, a bulleted list is often useful.)

Adds acm-pca under the umbrella of acm. Our AWS TAM confirmed that it is covered as part of ACM for compliance purposes.

What gif best describes this PR or how it makes you feel?

Completion checklist

[ ] Additions and changes have unit tests
[ ] Unit tests, Pylint, security testing, and Integration tests are passing.. GitHub actions does this automatically
[ ] The pull request has been appropriately labeled using the provided PR labels

salesforce-cla[bot] commented 3 years ago

Thanks for the contribution! Before we can merge this, we need @pkaeding to sign the Salesforce.com Contributor License Agreement.

pkaeding commented 3 years ago

I just signed the CLA, but I did see an error at one point. If I try signing again, though, it tells me I already signed. Is there anything more I should do there?

jdyke commented 3 years ago

I just signed the CLA, but I did see an error at one point. If I try signing again, though, it tells me I already signed. Is there anything more I should do there?

No, same thing happened to me. Future PRs will reflect your CLA! It may also update here if someone pushes a commit. I can take a look at this if @kmcquade doesn't mind.

Thanks for the PR!!

pkaeding commented 3 years ago

It may also update here if someone pushes a commit

Cool, that worked. Thanks @jdyke!

kmcquade commented 3 years ago

@jdyke sure feel free!

jdyke commented 3 years ago

LGTM, thanks for the add!