search

salesforce / aws-allowlister

Automatically compile an AWS Service Control Policy that ONLY allows AWS services that are compliant with your preferred compliance frameworks.
MIT License
221 stars 34 forks source link

Compliance Data update automation is failing #88

Closed kmcquade closed 2 years ago

kmcquade commented 3 years ago

See the failed GitHub actions: https://github.com/salesforce/aws-allowlister/actions/runs/1032122283

jdyke commented 3 years ago

It looks like it is breaking on a new entry into the DoD table AWS Diode from what I assume is a missing <a href=""> block

image

jdyke commented 3 years ago

Here is an example working service_name_cell = some_cells[0].contents[1] vs not:

Working:

[<td>
    <b>
        <a href="/datasync/">
            AWS DataSync
        </a>
    </b>
</td>, <td>
    ✓
</td>, <td>
    ✓
</td>, <td>
    ✓
</td>, <td>
    ✓
</td>, <td>
</td>]

Not working:

[<td>
    AWS Diode
</td>, <td>
</td>, <td>
</td>, <td>
</td>, <td>
</td>, <td>
    DISA Review
</td>]
kmcquade commented 3 years ago

Interesting. I'll have to take a look at this. Thanks for debugging

PatMyron commented 2 years ago

think this issue should still be open: https://github.com/salesforce/aws-allowlister/actions/workflows/update-compliance-data.yml?query=is:success https://github.com/salesforce/aws-allowlister/issues/97#issuecomment-954426149

kmcquade commented 2 years ago

Fixed by #99