Closed PatMyron closed 2 years ago
Thanks for the contribution! Before we can merge this, we need @PatMyron to sign the Salesforce.com Contributor License Agreement.
@PatMyron is there a reason for this?
@kmcquade fixes #88 (cron updating data again); currently fails with ModuleNotFoundError: No module named 'pandas'
spent hours trying to fix .xlsx
writing in Github actions instead, but .csv
seems sufficient if .xlsx
causes that much trouble in Github actions
It won't return the module not found error if you run pipenv install --dev
first :)
That works locally, but it's been running into No module named 'pandas'
even after pipenv install --dev
in Github actions:
https://github.com/salesforce/aws-allowlister/runs/4823542865?check_suite_focus=true
What does this PR do?
essentially reverting https://github.com/salesforce/aws-allowlister/pull/37 to fix https://github.com/salesforce/aws-allowlister/issues/88
What gif best describes this PR or how it makes you feel?
Completion checklist