salesforce / bazel-java-sdk

Apache License 2.0
26 stars 2 forks source link

Migrate raw Windows detection code to use the OSDetectionStrategy abstraction #32

Open plaird opened 3 years ago

plaird commented 3 years ago

In BazelPathHelper and a few other locations we have code checking if we are running on Windows:

But this isn't good. We have an abstraction for that, to allow us to test on other platforms (ie. Windows) without running that platform.

Change the BazelPathHelper and other offenders to use the abstraction.