search

salesforce / best

:trophy: Delightful Benchmarking & Performance Testing
https://opensource.salesforce.com/best
MIT License
95 stars 10 forks source link

feat: add autoscale to agent-hub #221

Closed ineedfat closed 4 years ago

ineedfat commented 4 years ago

Details

Note: Now that BEST is being rewritten, this PR is outdated and perhaps may be useful for reference consideration if autoscaling is a wanted feature in the future version of BEST.

This PR extends autoscaling support for AWS. The idea is to monitor the load on the agent-hub to determine when to scale up or down VMs running the best-agent. It is also intended for extensibility to other cloud platforms besides AWS in the future.

The AWS autoscale implementation targets the AutoScalingGroup in AWS for spawning and kill of VMs running best-agent by simply setting the "DesiredCapacity" property in the AutoScalingGroup object through the AWS API.

Does this PR introduce a breaking change?

If yes, please describe the impact and migration path for existing applications: Please check if your PR fulfills the following requirements:

diervo commented 4 years ago

@ineedfat why haven't you put this PR forward before? From your wording seems that you are no longer be pursuing this feature? If so we should talk, getting Best to scale is paramount for developer productivity.

All that being said, port this code to the new changes should be simpler and probably less verbose.

diervo commented 4 years ago

Closing this since we need to rethink the approach due to the new hub-agent protocol.