search

salesforce / best

:trophy: Delightful Benchmarking & Performance Testing
https://opensource.salesforce.com/best
MIT License
95 stars 10 forks source link

feature: Add cookie consent banner functionality to bestjs #274

Closed gregwhitworth closed 3 years ago

gregwhitworth commented 3 years ago

Details

THIS PR IS CURRENTLY A WIP FOR ONLINE TESTING IN STAGING. UPON COMPLETION OF TESTING I'LL REQUEST REVIEW

This PR will add branded cookie consent banners to the site for end users to accept/reject/modify cookie utilization on lwc.dev. In order to test this change's functionality make sure to use a VPN and use EMEA-1 in order to see the banner. In other VPN locales the only functional difference will be a cookie visible in the dev tools or if you click the "Cookie Preferences" link in the footer of the site.

The current PR has the following file being served from sfdstatic.com: https://a.sfdcstatic.com/enterprise/bestjs/uat/6140/oneTrust/scripttemplates/otSDKStub.js. This script is setup on the server as the test script and will work on heroku for testing.

Upon general approval and final test with any changes I will update that script to the following: https://a.sfdcstatic.com/enterprise/bestjs/prod/6140/oneTrust/scripttemplates/otSDKStub.js which is setup on the server to work with bestjs.dev.

Does this PR introduce a breaking change?

No

alrra commented 3 years ago

THIS PR IS CURRENTLY A WIP FOR ONLINE TESTING IN STAGING

@gregwhitworth Note: You can use GitHub's draft pull requests feature.