search

salesforce / ctrl

Conditional Transformer Language Model for Controllable Generation
https://arxiv.org/abs/1909.05858
BSD 3-Clause "New" or "Revised" License
1.87k stars 208 forks source link

using pytorch_generation.py: setting --temperature argument to any value causes a failure #41

Closed tanselmi closed 5 years ago

tanselmi commented 5 years ago

Works just fine without defining a temperature argument.

error comes out as the following:

pytorchtemperror

keskarnitish commented 5 years ago

Should be fixed in https://github.com/salesforce/ctrl/commit/9a365edd0caa5b6e91cbbde4b72db1e117877e91

Owing to the argument order, PyTorch assumed probs when I meant them to be logits.

Closing for now, reopen as necessary.

tanselmi commented 5 years ago

will check it out, thanks!