search

salesforce / decaNLP

The Natural Language Decathlon: A Multitask Challenge for NLP
BSD 3-Clause "New" or "Revised" License
2.34k stars 474 forks source link

import revtok for line 205 of metrics.py #3

Closed cclauss closed 6 years ago

cclauss commented 6 years ago

Also, typo in function name: corpus_gleu() --> corpus_bleu() to match the import on line 14.

flake8 testing of https://github.com/salesforce/decaNLP on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./metrics.py:205:17: F821 undefined name 'revtok'
    tokenizer = revtok.tokenize
                ^
./metrics.py:210:12: F821 undefined name 'corpus_gleu'
    return corpus_gleu(targets, outputs) * 100
           ^
2     F821 undefined name 'revtok'
2
salesforce-cla[bot] commented 6 years ago

Thanks for the contribution! Before we can merge this, we need @cclauss to sign the Salesforce.com Contributor License Agreement.

bmccann commented 6 years ago

Thanks for finding that! I'm just going to remove GLEU for now since we don't actually use it for the decaScore. a16f938cd783f6b7a6918add9ccf0177a3c1d348

bmccann commented 6 years ago

Going to close this PR for now unless we find a strong desire for revtok based GLEU.

salesforce-cla[bot] commented 5 years ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): cclauss c***@b***.ch. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.