salesforce / decaNLP

The Natural Language Decathlon: A Multitask Challenge for NLP
BSD 3-Clause "New" or "Revised" License
2.34k stars 474 forks source link

Use automated testing to find Python syntax errors #4

Closed cclauss closed 6 years ago

cclauss commented 6 years ago

http://flake8.pycqa.org will flag the Travis CI build if there are Python syntax errors or undefined names.

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety. This PR therefore recommends a flake8 run of these tests on the entire codebase.

bmccann commented 6 years ago

Awesome! I wrote all of this in Python 3 without any respect for things that would break in Python 2, so those tests will break. Everything is setup to run inside a Docker container with Python3, so I'm going to remove those tests for now. 6662a33dae348e65e03bbb593919fff1055a836c

salesforce-cla[bot] commented 5 years ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): cclauss c***@b***.ch. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.