salesforce / design-system-react

Salesforce Lightning Design System for React
https://design-system-react-site.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
921 stars 419 forks source link

Component updates in latest SLDS release #1500

Open interactivellama opened 6 years ago

interactivellama commented 6 years ago

This is super list of issues and should NOT be considered one issue to be fixed.

Fixes

Enhancements

New Variants/Examples

Net New Components

~* Illustrations (https://lightningdesignsystem.com/components/illustration/)~

pradumangoyal commented 5 years ago

Hi @interactivellama, can I take some issues from here to work upon?

interactivellama commented 5 years ago

Yes, please create new issues and then comment on this thread and I will cross them out in the above comment.

pradumangoyal commented 5 years ago

Opened issue #1869 to add inverse variant in the Avatar

pradumangoyal commented 5 years ago

@interactivellama, Kindly cross the following issue whose corresponding issues are created separately and being worked upon.

interactivellama commented 5 years ago

@pradumangoyal I updated the issue.

pulkonet commented 5 years ago

@interactivellama Please cross the following issues from above in lieu of the recently opened issues:

pulkonet commented 5 years ago

@interactivellama I wanted to make sure what exactly you mean by

Dropdowns (https://lightningdesignsystem.com/components/menus/#With-Overflow-Scrolling)/Combobox Need ability to specify length of the dropdown before scrolling https://lightningdesignsystem.com/components/menus/#With-Overflow-Scrolling

this point above. Because as far as I can see, passing a length prop to the <Dropdown /> component is changing the length as specified in SLDS.

Please let me know if I am missing something.

interactivellama commented 5 years ago

@pulkonet This list was copy and pasted from release notes from SLDS. As you say, it looks like DSR had already had that feature for a while.

In a way, you can look at SLDS as documentation blueprints and then all the various JS components as implementation. Sometimes the implementation is ahead of the documentation. 😄