salesforce / design-system-react

Salesforce Lightning Design System for React
https://design-system-react-site.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
919 stars 418 forks source link

Build an inline edit control (34) #153

Closed minevskiy closed 8 years ago

minevskiy commented 8 years ago

SFX Dashboards have custom inline input fields which should be replaced with accessible ones. An inline input is rendered as a label by default. When clicked (or tabbed in), it's rendered as an input. When the focus is lost, the current input value is saved and the input is rendered as a label again.

image

image

Acceptance criteria:

arunjeetsingh commented 8 years ago

From @jamin-hall

"Keith Willoughby's team is working on a project that will need to leverage the inline form pattern from SLDS. The best example is found on the Panels page https://core-202.lightningdesignsystem.com/components/panels (Click on Form with Inline Edit & Form with Inline Edit Active to see the different states)."

arunjeetsingh commented 8 years ago

@tweettypography @interactivellama The inline edit issue I was talking about. @jamin-hall provided details about where it is in the lightning design system.

arunjeetsingh commented 8 years ago

@minevskiy I assume you guys still need this for 204?

minevskiy commented 8 years ago

@arunjeetsingh , yes, we still need it to be accessibility compliant.