search

salesforce / design-system-react

Salesforce Lightning Design System for React
https://design-system-react-site.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
921 stars 419 forks source link

npm run update-snapshot -- -u results in snapshot images diffs that aren't diff. #1608

Open davidlygagnon opened 6 years ago

davidlygagnon commented 6 years ago

Just wanted to see if I was the only one getting this:

When I run npm run update-snapshot -- -u, I get a bunch of diffs on .pngs snapshot images. When looking at the diff, there does not seem to be any changes. I've been discarding them before committing but I feel we should probably fix this since it's a manual step I'd like to avoid doing over an over.

davidlygagnon commented 6 years ago

Example of diff that I get:

screen shot 2018-10-19 at 11 09 47 am

interactivellama commented 6 years ago

You are not. It's a big annoyance to me, too https://github.com/salesforce/design-system-react/issues/1099#issuecomment-431894554