search

salesforce / design-system-react

Salesforce Lightning Design System for React
https://design-system-react-site.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
921 stars 418 forks source link

Support menu item visible length in autocomplete combobox #2369

Open interactivellama opened 5 years ago

interactivellama commented 5 years ago

Currently in Combobox we have

    /**
     * Determines the height of the menu based on SLDS CSS classes. This only applies to the readonly variant. This is a `number`.
     */
    readOnlyMenuItemVisibleLength: PropTypes.oneOf([5, 7, 10]),

We should deprecated this property and make it menuItemVisibleLength and allow it to apply to autocomplete Comboboxes also.

Here is an example prop deprecation in App Launcher. https://github.com/salesforce/design-system-react/blob/master/components/app-launcher/index.jsx#L136

interactivellama commented 5 years ago

@PaulaIoana This is probably the better path forward than the solution I mentioned in the meeting.