search

salesforce / design-system-react

Salesforce Lightning Design System for React
https://design-system-react-site.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
916 stars 416 forks source link

Update Combobox/ Popover (variant ="error") Markup #2570

Closed Azmarie closed 4 years ago

Azmarie commented 4 years ago

Combobox/ Popover (variant ="error") has outdated markup compared to the latest version of SLDS.

There may be other places in the markup that might need to be updated as well. We should make sure that the Combobox and Popover markup is up-to-date with SLDS as part of fixing this issue.

I will work on this with @garygong.

welcome[bot] commented 4 years ago

Thanks for opening your first issue! :wave: If you have found this library helpful, please star it. A maintainer will try to respond within 7 days. If you haven’t heard anything by then, please bump this thread.

Azmarie commented 4 years ago

It seems that Combobox needs more updates that may have more impact, logged follow-up issue https://github.com/salesforce/design-system-react/issues/2586