Limit menu dropdown opening trigger keys

Azmarie commented 2 years ago

Fixes #2974

Please complete for every pull request

[x] First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[x] npm run lint:fix has been run and linting passes.
[x] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[x] Tests have been added for new props to prevent regressions in the future. See readme.
[x] Review the appropriate Storybook stories. Open http://localhost:9001/.
[x] Review tests are passing in the browser. Open http://localhost:8001/.
[x] Review markup conforms to SLDS by looking at DOM snapshot strings.

[ ] CircleCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.
Required only if there are markup / UX changes
[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

Azmarie commented 2 years ago

Could you take a look? @interactivellama @alexxpan @gfyhui @alexzherdev, thank you.

interactivellama commented 2 years ago

Logic looks good to me.

interactivellama commented 2 years ago

I'm guessing this is do to the logic change.

interactivellama commented 2 years ago

Azmarie commented 2 years ago

Thank you for taking a look @interactivellama, I will fix the close Menu on esc case now.

interactivellama commented 2 years ago

@alexzherdev @Azmarie Would either of you like to release? Here is how to do it. A patch.md file will trigger the build server to create a release build. https://github.com/salesforce/design-system-react/pull/2973

salesforce / design-system-react