salesforce / design-system-react

Salesforce Lightning Design System for React
https://design-system-react-site.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
916 stars 416 forks source link

Update version of icons #2979

Closed ashton-vaz closed 2 years ago

ashton-vaz commented 2 years ago

https://www.npmjs.com/package/@salesforce-ux/icons

welcome[bot] commented 2 years ago

Thanks for opening this pull request! :100:

This is a community-driven project, and we can't do it without your participation. Please check out our contributing guidelines and review the Contributor Checklist if you haven't already, to make sure everything is squared away. CircleCI will take about 10 minutes to run through the same items that are on the Contributor checklist with a pass/fail check below. Please fix any issues that cause CircleCI to fail or ask for clarification--we try, but sometimes the errors can be unclear. A maintainer will try to respond within 7 days. If you haven’t heard anything by then, please bump this thread. To ensure codebase quality, large code line changes may take more than 2 weeks to review, but may take longer depending on the number of pull requests in the queue. Feel free to ask for a status update at any time--you won't be bothering anyone. Once feedback has been given, please reply to the feedback giver once the feedback on been addressed, so that they can continue the review. If you need a release while you are waiting for a code review, you can publish a built tag to your own fork. See directions in the release README.

salesforce-cla[bot] commented 2 years ago

Thanks for the contribution! It looks like @ashton-vaz is an internal user so signing the CLA is not required. However, we need to confirm this.

interactivellama commented 2 years ago

@ashton-vaz Please sign the CLA. Since these are icons. Please post a screen shot of the icons storybook page.

interactivellama commented 2 years ago

I tracked down changes from icons 9.x to 10.x. The repo is not public though, but in 10.0.0, we optimized some of the existing svg files. Here are the notes from that icons release:

SVG Optimizations
Removed Generator comments
Removed id attributes from path and g tags
Removed title tags (alternative text provided when icon is consumed by the design system)
Removed desc tags
Removed empty g tags
Removed defs tags
Removed xml tags
Removed version attribute from svg tag
Removed DOCTYPE declarations
Removed xmlns:xlink attribute from svg tag
Removed deprecated icon font
ashton-vaz commented 2 years ago

I tracked down changes from icons 9.x to 10.x. The repo is not public though, but in 10.0.0, we optimized some of the existing svg files. Here are the notes from that icons release:

SVG Optimizations
Removed Generator comments
Removed id attributes from path and g tags
Removed title tags (alternative text provided when icon is consumed by the design system)
Removed desc tags
Removed empty g tags
Removed defs tags
Removed xml tags
Removed version attribute from svg tag
Removed DOCTYPE declarations
Removed xmlns:xlink attribute from svg tag
Removed deprecated icon font

Does 10.x refer to only 10.0.0? In that case, should I change it to 10.2.2 to reflect the most up to date version? @interactivellama

interactivellama commented 2 years ago

Using "10.x" will use the latest version of the library. I'm just sharing what the breaking change is so you can validate that the upgrade works correctly.

ashton-vaz commented 2 years ago

@ashton-vaz Please sign the CLA. Since these are icons. Please post a screen shot of the icons storybook page.

Screen Shot 2021-12-15 at 12 27 41 PM
ashton-vaz commented 2 years ago

@interactivellama I just signed the CLA, how do I re-trigger the check?

interactivellama commented 2 years ago

It looks like opening and closing the PR will work for the CLA... It's been flakey recently.

welcome[bot] commented 2 years ago

Congrats on merging your first pull request to Design System React! :tada: If you have a moment, please fill out this five question survey, we would appreciate it. On behalf of Salesforce's customers, partners, product specialists and employees, we would like offer sincere thanks and appreciation for helping make our user experience better. We look forward to working with you more in the future. This definitely calls for a high five! Alt High Five

interactivellama commented 2 years ago

@ashton-vaz Please proceed with release PR.

ashton-vaz commented 2 years ago

@ashton-vaz Please proceed with release PR.

Thank you!