salesforce / design-system-react

Salesforce Lightning Design System for React
https://design-system-react-site.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
916 stars 416 forks source link

Combobox - Incorrect PropTypes type for 'disabled' prop in options array. #2988

Closed Streudal closed 2 years ago

Streudal commented 2 years ago

I'm getting an error for the 'disabled' prop that is part of option object for the options prop on the Combobox component. Here is the error:

image

and the current shape of the object for options in combobox.jsx: image

I believe the fix is to just make the 'disabled' prop PropTypes.bool instead of PropTypes.boolean and all should be good to go. Just like this: image

I tested this by changing it from the node_modules directory and the error went away. Please let me know if I can be of any more assistance in this.

welcome[bot] commented 2 years ago

Thanks for opening your first issue! :wave: If you have found this library helpful, please star it. A maintainer will try to respond within 7 days. If you haven’t heard anything by then, please bump this thread.

ashutosh887 commented 2 years ago

I would like to work on this Issue Please assign to me and guide me once

DevGautam2000 commented 2 years ago

Would like to work on this issue. Please assign this to me.