search

salesforce / design-system-react

Salesforce Lightning Design System for React
https://design-system-react-site.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
915 stars 416 forks source link

Combobox findDOMNode is deprecated in StrictMode #3013

Open dlferro opened 2 years ago

dlferro commented 2 years ago

I've run into this warning using the combobox with React 17. It appears that it was tackled previously with popovers. @interactivellama is the gist of this issue just replacing it with components reference? I'm assuming in this instance it's a utility or sub component of comobox.

pmartin35 commented 2 years ago

Also running into this

interactivellama commented 2 years ago

This is likely an issue found in the https://github.com/salesforce/design-system-react/blob/master/utilities/keyboard-navigate.js and https://github.com/salesforce/design-system-react/blob/master/utilities/keyboard-navigable-dialog.js which calls findDOMNode to check for event target.

yes, it likely can be updated to compare refs.