salesforce / design-system-react

Salesforce Lightning Design System for React
https://design-system-react-site.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
913 stars 415 forks source link

Upgrade react-text-truncate to latest version #3052

Closed pmartin35 closed 2 years ago

pmartin35 commented 2 years ago

Fixes the following warnings on React 17 and React 18 due to the currently included version of react-text-truncate not having up to date peer dependencies.

Screen Shot 2022-06-21 at 2 08 20 PM

CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

REVIEWER checklist (do not remove)

welcome[bot] commented 2 years ago

Thanks for opening this pull request! :100:

This is a community-driven project, and we can't do it without your participation. Please check out our contributing guidelines and review the Contributor Checklist if you haven't already, to make sure everything is squared away. CircleCI will take about 10 minutes to run through the same items that are on the Contributor checklist with a pass/fail check below. Please fix any issues that cause CircleCI to fail or ask for clarification--we try, but sometimes the errors can be unclear. A maintainer will try to respond within 7 days. If you haven’t heard anything by then, please bump this thread. To ensure codebase quality, large code line changes may take more than 2 weeks to review, but may take longer depending on the number of pull requests in the queue. Feel free to ask for a status update at any time--you won't be bothering anyone. Once feedback has been given, please reply to the feedback giver once the feedback on been addressed, so that they can continue the review. If you need a release while you are waiting for a code review, you can publish a built tag to your own fork. See directions in the release README.

salesforce-cla[bot] commented 2 years ago

Thanks for the contribution! Before we can merge this, we need @pmartin35 to sign the Salesforce.com Contributor License Agreement.

pmartin35 commented 2 years ago

Thanks for the contribution! Before we can merge this, we need @pmartin35 to sign the Salesforce.com Contributor License Agreement.

FYI - I did sign the Agreement, not sure why CI is failing

pmartin35 commented 2 years ago

@interactivellama Bump 🙂

anish commented 2 years ago

reopening to rekick cla bot

welcome[bot] commented 2 years ago

Congrats on merging your first pull request to Design System React! :tada: If you have a moment, please fill out this five question survey, we would appreciate it. On behalf of Salesforce's customers, partners, product specialists and employees, we would like offer sincere thanks and appreciation for helping make our user experience better. We look forward to working with you more in the future. This definitely calls for a high five! Alt High Five