Closed 2FALockedMeOutOfMyAcct closed 1 year ago
Thanks for opening this pull request! :100:
This is a community-driven project, and we can't do it without your participation. Please check out our contributing guidelines and review the Contributor Checklist if you haven't already, to make sure everything is squared away. CircleCI will take about 10 minutes to run through the same items that are on the Contributor checklist with a pass/fail check below. Please fix any issues that cause CircleCI to fail or ask for clarification--we try, but sometimes the errors can be unclear. A maintainer will try to respond within 7 days. If you haven’t heard anything by then, please bump this thread. To ensure codebase quality, large code line changes may take more than 2 weeks to review, but may take longer depending on the number of pull requests in the queue. Feel free to ask for a status update at any time--you won't be bothering anyone. Once feedback has been given, please reply to the feedback giver once the feedback on been addressed, so that they can continue the review. If you need a release while you are waiting for a code review, you can publish a built tag to your own fork. See directions in the release README.
Minimized and expanded states:
3 votes in favor of this behavior: @gfyhui , @alexxpan and Jonathon
@alexzherdev Merge when you ready to.
Not super important for this simple component, but I wonder if we should encourage new components to be written as functions. At this point I don't think there are any pre-16.8 consumers?
Congrats on merging your first pull request to Design System React! :tada:
If you have a moment, please fill out this five question survey, we would appreciate it.
On behalf of Salesforce's customers, partners, product specialists and employees, we would like offer sincere thanks and appreciation for helping make our user experience better. We look forward to working with you more in the future.
This definitely calls for a high five!
@alexzherdev I'm cool with that. Please update the docs when convenient. I believe DataTable has hooks in it.
Also, love the account name: @2FALockedMeOutOfMyAcct
Thanks for the reviews and merging. When will the next DSR release be @interactivellama @alexzherdev ?
@interactivellama is the automated release build still broken?
Yes.
I could use some help in triaging the authentication, since the security protections went up.
@2FALockedMeOutOfMyAcct Please open a release PR and I will pull down and push up a tag.
@interactivellama I opened #3063 if that's what you meant?
I'll try to get this out by End of week.
There are additional issues with the NPM publishing process. I'm in talks with Jim in OSS group on getting different permissions set up. The tag is present in Github but we do not have a NPM package up today.
Additional description
Adds Docked Composer to DSR
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fix
has been run and linting passes.components/component-docs.json
CI tests pass (npm test
).REVIEWER checklist (do not remove)
components/component-docs.json
tests.Required only if there are markup / UX changes
last-slds-markup-review
inpackage.json
and push.last-accessibility-review
, topackage.json
and push.npm run local-update
within locally cloned site repo to confirm the site will function correctly at the next release.