Closed BenjaminWFox-MuleSoft closed 1 year ago
Thanks for opening your first issue! :wave: If you have found this library helpful, please star it. A maintainer will try to respond within 7 days. If you haven’t heard anything by then, please bump this thread.
Looks good! Please proceed. Be sure to mention the props in the class comments, since there are no propTypes.
We have some release pipeline blockers right now for NPM publishing, so I can't promise a date, but if we can't hit it, self publish on a Git tag is an option until the pipeline issue can be mitigated.
@interactivellama Added https://github.com/salesforce/design-system-react/pull/3071 to address this.
Regarding the Card component, it doesn't de-structure
aria-
(ordata-
) props (like the way Button does for example).Since the Card renders an
article
which shows up in the Landmarks menu (on screen reader on MacOS at least) it would be great to be able to give the element a more accessible label.I'm happy to implement & submit a PR for this!
I think it would be sufficient to do something like this, but let me know:
cc @interactivellama