salesforce / design-system-react

Salesforce Lightning Design System for React
https://design-system-react-site.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
913 stars 415 forks source link

Migrate react-highlighter to react-highlighter-ts #3080

Closed pmartin35 closed 1 year ago

pmartin35 commented 1 year ago

Fixes the following npm warnings when installing SLDS React on React 17 and React 18 due to the currently included version of react-highlighter not having up to date peer dependencies.

Screen Shot 2022-11-18 at 8 19 56 PM

Fix was done by migrating from abandoned react-highlighter to a maintained package react-highlighter-ts.

Confirmed through the SLDS project storybook to be working on React 17 and on codesandbox that it seems to also work for React 18:

Screenshot 2022-11-19 at 14 02 29

CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

REVIEWER checklist (do not remove)

pmartin35 commented 1 year ago

Bump 🙂