Fix Tooltip for PageHeader components

shravansnyu commented 1 year ago

Fixes #3090

Additional description

[UI] Shows truncated text in tooltip.

CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

[ ] First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[X] npm run lint:fix has been run and linting passes.
[ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[X] Tests have been added for new props to prevent regressions in the future. See readme.
[X] Review the appropriate Storybook stories. Open http://localhost:9001/.
[X] Review tests are passing in the browser. Open http://localhost:8001/.
[X] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] CircleCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[X] Tests have been added for new props to prevent regressions in the future. See readme.
[X] Review the appropriate Storybook stories. Open http://localhost:9001/.
[X] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[X] Review markup conforms to SLDS by looking at DOM snapshot strings.
Required only if there are markup / UX changes
[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

welcome[bot] commented 1 year ago

Thanks for opening this pull request! :100:

This is a community-driven project, and we can't do it without your participation. Please check out our contributing guidelines and review the Contributor Checklist if you haven't already, to make sure everything is squared away. CircleCI will take about 10 minutes to run through the same items that are on the Contributor checklist with a pass/fail check below. Please fix any issues that cause CircleCI to fail or ask for clarification--we try, but sometimes the errors can be unclear. A maintainer will try to respond within 7 days. If you haven’t heard anything by then, please bump this thread. To ensure codebase quality, large code line changes may take more than 2 weeks to review, but may take longer depending on the number of pull requests in the queue. Feel free to ask for a status update at any time--you won't be bothering anyone. Once feedback has been given, please reply to the feedback giver once the feedback on been addressed, so that they can continue the review. If you need a release while you are waiting for a code review, you can publish a built tag to your own fork. See directions in the release README.

salesforce-cla[bot] commented 1 year ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Shravan Kumaran s***@s***.com. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

salesforce-cla[bot] commented 1 year ago

Thanks for the contribution! It looks like @shravansnyu is an internal user so signing the CLA is not required. However, we need to confirm this.

interactivellama commented 1 year ago

@shravansnyu Great bug find. Thanks, I will get this merged in shortly.

welcome[bot] commented 1 year ago

Congrats on merging your first pull request to Design System React! :tada: If you have a moment, please fill out this five question survey, we would appreciate it. On behalf of Salesforce's customers, partners, product specialists and employees, we would like offer sincere thanks and appreciation for helping make our user experience better. We look forward to working with you more in the future. This definitely calls for a high five! Alt High Five

chuyler commented 1 year ago

This fix is not correct. The detail block already has a tooltip that is set to display on delay. This blue tooltip needs to be removed entirely.

salesforce / design-system-react