salesforce / design-system-react

Salesforce Lightning Design System for React
https://react.lightningdesignsystem.com/
BSD 3-Clause "New" or "Revised" License
909 stars 411 forks source link

PageHeader: Remove tooltip from default details field #3099

Closed interactivellama closed 1 year ago

interactivellama commented 1 year ago

Fixes https://github.com/salesforce/design-system-react/pull/3091#issuecomment-1441214335

Additional description

This removes the dual title and tooltip now that truncate is present. If you want a Tooltip, please add one.


CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

REVIEWER checklist (do not remove)

interactivellama commented 1 year ago

@chuyler Could you review this for me?

chuyler commented 1 year ago

The second (gray) tooltip comes from title={label}. I'm not sure which tooltip is the desired one but it appears that this version will work fine. The other option is to keep all this code you are removing and just eliminate title={label}.