Closed ilee-salesforce closed 10 months ago
Thanks for opening this pull request! :100:
This is a community-driven project, and we can't do it without your participation. Please check out our contributing guidelines and review the Contributor Checklist if you haven't already, to make sure everything is squared away. CircleCI will take about 10 minutes to run through the same items that are on the Contributor checklist with a pass/fail check below. Please fix any issues that cause CircleCI to fail or ask for clarification--we try, but sometimes the errors can be unclear. A maintainer will try to respond within 7 days. If you haven’t heard anything by then, please bump this thread. To ensure codebase quality, large code line changes may take more than 2 weeks to review, but may take longer depending on the number of pull requests in the queue. Feel free to ask for a status update at any time--you won't be bothering anyone. Once feedback has been given, please reply to the feedback giver once the feedback on been addressed, so that they can continue the review. If you need a release while you are waiting for a code review, you can publish a built tag to your own fork. See directions in the release README.
Thanks for the contribution! It looks like @ilee-salesforce is an internal user so signing the CLA is not required. However, we need to confirm this.
@interactivellama Hi Stephen Can you take a look at this PR and let me know if this makes sense?
Thank you for the PR.
My understanding from the SLDS maintainers is that this is a temporary suffix until color contrast goes GA. Are you able to use the suffix version until the color changes go GA?
@interactivellama https://salesforce-internal.slack.com/archives/C04A056KE82/p1690224533494079
I got the information from this thread. Looks like it was suggested to use the -wcag
version.
@ilee-salesforce It looks like we don't have a near term date for the color contrast to move into the non-suffixed version, so we can move forward with this. Please pull down storybook and give a general review of components.
Oh, also, please sign the contributor CLA
@interactivellama I signed that CLA thing about three times already and it doesn't seem to work for some reason
looks like CLA is working. lint is failing https://circleci.com/gh/salesforce/design-system-react/2635?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary
Nevermind, it's the CI service that failed.
@interactivellama Looks like all the checks are good. I am going over the storybook one last time to make sure nothing is broken.
@interactivellama I went over all of the components in the storybook with the new SLDS version and all of them seem to work without any error.
Congrats on merging your first pull request to Design System React! :tada:
If you have a moment, please fill out this five question survey, we would appreciate it.
On behalf of Salesforce's customers, partners, product specialists and employees, we would like offer sincere thanks and appreciation for helping make our user experience better. We look forward to working with you more in the future.
This definitely calls for a high five!
Salesforce teams are getting TDs to update all UI in MANAGED PACKAGE to have 3:1 color contrast for functional UI elements and 4.5:1 color contrast for text. Example TD (https://gus.lightning.force.com/lightning/r/ADM_Team_Dependency__c/a0nEE000000HnxBYAS/view)
For those apps that use @salesforce-ux/design-system, the newly updated version with wcag compliance is available with
2.21.3-wcag
(https://www.npmjs.com/package/@salesforce-ux/design-system/v/2.21.3-wcag)I am simply updating the version to the wcag compliant one.