search

salesforce / dockerfile-image-update

A tool that helps you get security patches for Docker images into production as quickly as possible without breaking things
BSD 3-Clause "New" or "Revised" License
136 stars 48 forks source link

Github Search throws exception if the search query is longer than 128 characters #314

Open avimanyum opened 2 years ago

avimanyum commented 2 years ago

Describe the bug While searching for an image in git repos, github search API throws an exception if the query length is greater than 128 characters.

To Reproduce Steps to reproduce the behavior:

  1. Generate an image from a repo which has a long name (preferably > 128 characters)
  2. Run DFIU on the docker image that gets generated from the above repo
  3. Notice that the search API throws an exception while looking for Dockerfiles where this image is being used.

Expected behavior Provide a workaround to handle scenarios where the query length is greater than 128 characters.

Screenshots Caused by: org.kohsuke.github.HttpException: {"message":"Validation Failed","errors":[{"message":"The search is longer than 128 characters.","resource":"Search","field":"q","code":"invalid"}],"documentation_url":"https://docs.github.com/enterprise/3.1/v3/search/"}

Computing Environment (please complete the following information):

Additional context Add any other context about the problem here.

pchugh17 commented 2 years ago

Github documentation says:

There are some limits to the length of the queries when searching across GitHub:

Queries longer than 256 characters are not supported
You can't construct a query using more than five AND, OR, or NOT operators
Specific search types, such as code search, might have additional limitations. Check the documentation for these search types for more information.