search

salesforce / eslint-config-lwc

Opinionated ESLint configurations for LWC projects
MIT License
112 stars 36 forks source link

chore(deps): replace ~ dependencies with ^ #37

Closed markcatley closed 3 years ago

markcatley commented 3 years ago

I have some tools I've written running in the same repository as my lwcs and I'm running into some problems updating dependencies because of the restrictiveness of the ~ dependencies in this repo.

Would you consider loosening the dependencies to ^ dependencies?

~ dependencies only allow the patch version to be updated. ^ dependencies allow the patch and minor version to be updated.

salesforce-cla[bot] commented 3 years ago

Thanks for the contribution! Before we can merge this, we need @markcatley to sign the Salesforce.com Contributor License Agreement.

pmdartus commented 3 years ago

@markcatley Thanks for taking the time to open this pull request.

We have been burned multiple times in the past by downstream packages introducing breaking in minor updates. In order to prevent potential breakage for customers, we decided to match against ~ instead of ^ for all the dependencies. I will close this PR for now since we will not migrate to ^ matching.

Feel free to open an issue so we can discuss your upgrade issue, without having to change the dependencies.

As a side note, I fully support adding support for eslint 7 in the peer dependencies. That being said I think we should also add a new step on the CI to run the test on both eslint 6 and eslint 7. Would you be interested in working on this?