search

salesforce / fsnet

BSD 3-Clause "New" or "Revised" License
113 stars 23 forks source link

Correct code errors in fw_chunks(self) #9

Open Irelandr opened 6 months ago

Irelandr commented 6 months ago

idx = idx.unsqueeze(1).float() old_w = ww @ idx → v = v.unsqueeze(1).float() old_w = ww @ v

Irelandr commented 6 months ago

may be you need v.detach()

LiuYasuo commented 5 months ago

I have found the same problem in this code. Moreover, did you notice the memory leak issue when running this code.

Irelandr commented 5 months ago

No，I ran fsnet on ETTh and there were no problems.

LiuYasuo commented 5 months ago

If you have the time, I hope you could run the original code of FSnet again. And you can use the "top" command to check the memory usage of this process while it is running. Then you will find that the memory occupied by this process continues to increase.

Irelandr commented 5 months ago

It seems that I didn't encounter the problem you said.

LiuYasuo commented 5 months ago

Could you give me your way of contact such as Wechat,? I hope we could discuss this problem in more detail. Thanks!

Irelandr commented 5 months ago

it's irelandr

ooooooover commented 4 months ago

Could you give me your way of contact such as Wechat,? I hope we could discuss this problem in more detail. Thanks!

Can we add a wechat to chat in detail, I have some doubts too.Wechat can be sent to my email: zhangweiyang12138@gmail.com