search

salesforce / grpc-java-contrib

Useful extensions for the grpc-java library
BSD 3-Clause "New" or "Revised" License
220 stars 34 forks source link

Fixed: FileInputStream stays open until you close the JVM process #112

Closed kjarrio closed 5 years ago

kjarrio commented 5 years ago

Fixed: FileInputStream stays open until you close the JVM process, which causes the dump file to get locked.

salesforce-cla[bot] commented 5 years ago

Thanks for the contribution! Before we can merge this, we need @kjarrio to sign the Salesforce.com Contributor License Agreement.

rmichela commented 5 years ago

Thanks for the fix! Do you need this released immediately?

kjarrio commented 5 years ago

No, I managed to patch it yesterday by replacing the single file. I've got some time on my hands before getting back to work, so I might as well contribute a bit more, is there anything specific you need or want for the jprotoc project? I'll make a pull request later adding a few more examples of usage to get people started as the couple of example generators in there don't go into too much detail.

rmichela commented 5 years ago

Additional documentation and examples would be great!

rmichela commented 5 years ago

Released in 1.0.0