search

salesforce / grpc-java-contrib

Useful extensions for the grpc-java library
BSD 3-Clause "New" or "Revised" License
220 stars 34 forks source link

Any plans to update for proto 3.9.1 and grpc 2.4.0 libs? #123

Closed lt-schmidt-jr closed 4 years ago

lt-schmidt-jr commented 4 years ago

Looks like the protocol buffers dependency are quite out of date, any plans to update to 1.24.0</grpc.version>

3.9.1
rmichela commented 4 years ago

You should be able to use reactive-grpc with newer versions of gRPC. Are these dependencies causing problems?

lt-schmidt-jr commented 4 years ago

The specific problem I am encountering is adding an options java file compiled with proto 3.9, while attempting the write my custom plugin using jprotoc (thank you). Specifically UnusedPrivateParameter is not found in the older libs jprotoc uses. Once I build jprotoc to newer proto java libs, it seems I can move forward

rmichela commented 4 years ago

👍 can you submit a PR?

lt-schmidt-jr commented 4 years ago

Will do, however, it is not fully baked in that it seems to break some of the other (non-jproto-c) components

rmichela commented 4 years ago

i can look into it, too

lt-schmidt-jr commented 4 years ago

PR submitted https://github.com/salesforce/grpc-java-contrib/pull/124 Again, thank you for building this package.

lt-schmidt-jr commented 4 years ago

@rmichela would you mind releasing the changes, or let me know when you are planning next release?

rmichela commented 4 years ago

Released